Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add go mod to manage modules (dependencies) #81

Merged
merged 2 commits into from
Aug 28, 2020
Merged

Add go mod to manage modules (dependencies) #81

merged 2 commits into from
Aug 28, 2020

Conversation

jmonteiro
Copy link
Contributor

Recently we had an issue with vitess.io/vitess/go/pools, where they changed an interface used on goworker, breaking it. It is fixed on #78, but ideally we should just adopt go mod.

Copy link
Owner

@benmanns benmanns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@benmanns benmanns merged commit bdc218d into benmanns:master Aug 28, 2020
@jmonteiro jmonteiro deleted the go-mod branch August 28, 2020 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants